Skip to content

chore: upgrade oxlint to 1.71.0 and enable react/react-compiler rule#10203

Merged
reidbarber merged 12 commits into
mainfrom
upgrade-oxlint-1-70-0
Jun 24, 2026
Merged

chore: upgrade oxlint to 1.71.0 and enable react/react-compiler rule#10203
reidbarber merged 12 commits into
mainfrom
upgrade-oxlint-1-70-0

Conversation

@reidbarber

@reidbarber reidbarber commented Jun 15, 2026

Copy link
Copy Markdown
Member

Upgrades oxlint to 1.71.0, which includes the native react compiler rule (added in 1.70.0).

Benchmark results on M4 Max MPB:

Before (1.63.0 + JS plugin) After (1.70.0 + native)
Wall time ~18.5s ~3.2s
CPU (user) ~31s ~7.3s
Speedup 5.8×

The native rule caught more violations than the JS plugin (585 total vs. 43 total).

Category Count
Refs (ref access during render) 197
Immutability (mutating props/hook values) 150
Hooks (rules of hooks) 85
CapitalizedCalls 83
MemoDependencies 27
EffectSetState 10
PreserveManualMemo 9
StaticComponents, Purity, etc. ~24

I suppressed them in this PR, but we can decide if there's any we want to fix for now.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot

rspbot commented Jun 15, 2026

Copy link
Copy Markdown

@reidbarber reidbarber changed the title chore: upgrade oxlint to 1.70.0 chore: upgrade oxlint to 1.70.0 and enable react/react-compiler rule Jun 15, 2026
Comment thread packages/@adobe/react-spectrum/src/buttongroup/ButtonGroup.tsx
Comment thread packages/@adobe/react-spectrum/src/checkbox/Checkbox.tsx Outdated
@rspbot

rspbot commented Jun 16, 2026

Copy link
Copy Markdown

snowystinger
snowystinger previously approved these changes Jun 18, 2026
Resolve conflicts in keyboard shortcut refactors while preserving
oxlint react-compiler suppressions and select anchor selection fix.
snowystinger
snowystinger previously approved these changes Jun 24, 2026
@rspbot

rspbot commented Jun 24, 2026

Copy link
Copy Markdown

@reidbarber reidbarber enabled auto-merge June 24, 2026 22:34
@reidbarber reidbarber changed the title chore: upgrade oxlint to 1.70.0 and enable react/react-compiler rule chore: upgrade oxlint to 1.71.0 and enable react/react-compiler rule Jun 24, 2026
@rspbot

rspbot commented Jun 24, 2026

Copy link
Copy Markdown

@reidbarber reidbarber added this pull request to the merge queue Jun 24, 2026
Merged via the queue into main with commit 7ef2302 Jun 24, 2026
32 checks passed
@reidbarber reidbarber deleted the upgrade-oxlint-1-70-0 branch June 24, 2026 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants